[webkit-changes] [WebKit/WebKit] 793932: Web Inspector: Font Panel: CSS font property value...

[Frances Cornwall]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 793932ceb15afa7dcbcfa99af428131244f7a15d
      https://github.com/WebKit/WebKit/commit/793932ceb15afa7dcbcfa99af428131244f7a15d
  Author: Frances Cornwall <frances_c at cox.net>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Models/FontStyles.js

  Log Message:
  -----------
  Web Inspector: Font Panel: CSS font property values marked !important don't get overridden when using the interactive editing controls.
https://bugs.webkit.org/show_bug.cgi?id=258975

Reviewed by Devin Rousso.

If a CSS class has a !important tag on a property the slider does not work correctly.
This is due to us modifying the inline style, and the inline style is being overriden by
the css class !important property.

We can address this by checking if the !important property is being applied already
during _computeProperty(), and then if it is then append !important in the
writeFontVariation().

Rename resultProperties to resultProperty inside of _computeProperty() because there
is a single property being handled.

Delete _effectivePropertyValueForName function since it is not in use and create it in
_computeProperty instead to be used for resultProperty.isImportant.

* Source/WebInspectorUI/UserInterface/Models/FontStyles.js:
(WI.FontStyles.prototype.writeFontVariation):
(WI.FontStyles):

Canonical link: https://commits.webkit.org/275389@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications