[webkit-changes] [WebKit/WebKit] dd25a0: Regression (Safari 17 vs 16.5, 261003 at main): heigh...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd25a04355e3584bf5615720b1e48f90796b6c1e
      https://github.com/WebKit/WebKit/commit/dd25a04355e3584bf5615720b1e48f90796b6c1e
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-02-27 (Tue, 27 Feb 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  Regression (Safari 17 vs 16.5, 261003 at main): height collapsing on auto-height image when container-type set on parent
https://bugs.webkit.org/show_bug.cgi?id=268874

Reviewed by Alan Baradlay.

In r261003 isComputingSizeOrInlineSizeContainment was used which did not consider grid track sizing direction. Fix that
by using shouldCheckExplicitIntrinsicInnerLogicalSize which will take the direction into account.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-flex-fraction.html: Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/275376@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications