[webkit-changes] [WebKit/WebKit] eaa2c4: ASSERT_WITH_SECURITY_IMPLICATION reached on Messag...

NKRosario noreply at github.com
Mon Feb 26 23:11:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eaa2c46c39229151c6396f7c86d74a2245ffa49c
      https://github.com/WebKit/WebKit/commit/eaa2c46c39229151c6396f7c86d74a2245ffa49c
  Author: Nicole Rosario <nicole_rosario at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    A LayoutTests/ipc/send-ignored-network-message-expected.txt
    A LayoutTests/ipc/send-ignored-network-message.html
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

  Log Message:
  -----------
  ASSERT_WITH_SECURITY_IMPLICATION reached on Messages::NetworkProcess in NetworkConnectionToWebProcess::didReceiveMessage()
https://bugs.webkit.org/show_bug.cgi?id=270006
rdar://123087621

Reviewed by Alex Christensen and Chris Dumez.

Replace assertions checking that `decoder.messageReceiverName() !=
Messages::NetworkProcess::messageReceiverName()` with MESSAGE_CHECK.
Network messages from the web content process are safely ignored
elsewhere already so the assert is not needed

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):

Canonical link: https://commits.webkit.org/275369@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list