[webkit-changes] [WebKit/WebKit] 4d9c89: [JSC] Do not upgrade CallLinkInfo when the target ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4d9c892d5723e95cab0c627d5f46f8d8da236294
      https://github.com/WebKit/WebKit/commit/4d9c892d5723e95cab0c627d5f46f8d8da236294
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-26 (Mon, 26 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/CodeBlock.cpp
    M Source/JavaScriptCore/runtime/ScriptExecutable.cpp
    M Source/JavaScriptCore/runtime/ScriptExecutable.h

  Log Message:
  -----------
  [JSC] Do not upgrade CallLinkInfo when the target is also already dead
https://bugs.webkit.org/show_bug.cgi?id=270119
rdar://123651394

Reviewed by Justin Michaud.

Probably does not matter much but let's make it defensive. When running unlinkOrUpgrade,
if it is invoked through jettisoning due to GC end-phase check, we should check whether the new target CodeBlock is also dead,
and if it is dead, not passing it.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
* Source/JavaScriptCore/runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::prepareForExecutionImpl):
* Source/JavaScriptCore/runtime/ScriptExecutable.h:

Canonical link: https://commits.webkit.org/275356@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications