[webkit-changes] [WebKit/WebKit] 19f884: [MSE] Media from the TimeRange containing currentT...

Jean-Yves Avenard noreply at github.com
Sun Feb 25 21:27:54 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 19f884773fcae860a4dfb9346d56c55a89c630f4
      https://github.com/WebKit/WebKit/commit/19f884773fcae860a4dfb9346d56c55a89c630f4
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-25 (Sun, 25 Feb 2024)

  Changed paths:
    A LayoutTests/media/media-source/media-managedmse-eviction-expected.txt
    A LayoutTests/media/media-source/media-managedmse-eviction.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/SourceBufferPrivate.cpp

  Log Message:
  -----------
  [MSE] Media from the TimeRange containing currentTime can be evicted when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=270034
rdar://problem/123556056

Reviewed by Eric Carlson.

We want none of the data contiguous from the currentTime to the next discontinuity to be
evicted to ensure continuous playback.
This is inline with Google's proposal for having Eviction Policies.

The comments in the eviction code indicated as such, but a logic error would have made
the end of the current range be truncated if it was followed by another range
after a discontinuity.

* LayoutTests/media/media-source/media-managedmse-eviction-expected.txt: Added.
* LayoutTests/media/media-source/media-managedmse-eviction.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::evictFrames):

Canonical link: https://commits.webkit.org/275306@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list