[webkit-changes] [WebKit/WebKit] dc6a01: Enable UnifiedPDF compile time flag on Cocoa platf...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc6a01c9fd207e1b1394a1cb8261b410a1909cf6
      https://github.com/WebKit/WebKit/commit/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WTF/wtf/PlatformEnableCocoa.h
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp
    M Tools/WebKitTestRunner/TestOptions.cpp

  Log Message:
  -----------
  Enable UnifiedPDF compile time flag on Cocoa platforms
https://bugs.webkit.org/show_bug.cgi?id=269440

Reviewed by Simon Fraser.

* Source/WTF/wtf/PlatformEnableCocoa.h:
Turn it on.

* Source/WTF/wtf/PlatformHave.h:
Add a define for some CG API added recently.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::pdfElementTypesForPluginPoint const):
(WebKit::UnifiedPDFPlugin::handlePDFActionForAnnotation):
Adopt defines for not-yet-everywhere API.

(WebKit::UnifiedPDFPlugin::shouldShowDebugIndicators const):
(WebKit::UnifiedPDFPlugin::didChangeSettings):
(WebKit::UnifiedPDFPlugin::paintPDFContent):
Fix the build on old compilers.

* Tools/WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):
Disable by default in test runner for now, so we have to explicitly opt tests into unified PDF.
We'll swap this at some point.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp:
(WebKit::pluginInfoVector):
(WebKit::WebPluginInfoProvider::pluginInfo):
(WebKit::WebPluginInfoProvider::webVisiblePluginInfo):
Fix a longstanding mis-assumption that if ENABLE(PDF_PLUGIN) is true, we
will always have PDF plugins (the macOS version was never runtime-disableable).
This mistake previously caused us to pretend to have a PDF plugin on iOS
when Unified PDF was enabled at build time, even if it was disabled at runtime,
breaking our fallback to PDFDocumentImage-based presentation.

Canonical link: https://commits.webkit.org/275274@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications