[webkit-changes] [WebKit/WebKit] 617715: [JSC] Clean up CallLinkInfo::unlinlkOrUpgradeImpl ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 617715243dc578fef6ca3a32ab2cb017e8e1deb5
      https://github.com/WebKit/WebKit/commit/617715243dc578fef6ca3a32ab2cb017e8e1deb5
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/CallLinkInfo.cpp
    M Source/JavaScriptCore/bytecode/Repatch.cpp

  Log Message:
  -----------
  [JSC] Clean up CallLinkInfo::unlinlkOrUpgradeImpl to make `remove` consistent
https://bugs.webkit.org/show_bug.cgi?id=270004
rdar://122611742

Reviewed by Alexey Shvayka.

1. In CallLinkInfo::unlinkOrUpgradeImpl, let's always start with removing it from the list. If we upgrade, we anyway re-chain it to the new CodeBlock.
   So there is no possible case that we would like to keep the current link.
2. Let's make linked / unlinked state consistent more by moving `remove` code inside CallLinkInfo itself. And always check `isOnList` before calling it.

* Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlinkOrUpgradeImpl):
(JSC::CallLinkInfo::setStub):
* Source/JavaScriptCore/bytecode/Repatch.cpp:
(JSC::linkPolymorphicCall):

Canonical link: https://commits.webkit.org/275256@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications