[webkit-changes] [WebKit/WebKit] 229250: Rework WebPageProxy::creationParameters function p...

[Gerald Squelart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 229250e6cd7fa24eab4423c217c814d977dc60e7
      https://github.com/WebKit/WebKit/commit/229250e6cd7fa24eab4423c217c814d977dc60e7
  Author: Gerald Squelart <g_squelart at apple.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/RemotePageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  Rework WebPageProxy::creationParameters function parameters
https://bugs.webkit.org/show_bug.cgi?id=269823
rdar://116201784

Reviewed by Alex Christensen.

Two calls to WebPageProxy::creationParameters() modify the parameters before
using them in messages. These calls are now forced to instead provide all
the necessary information at once, and the returned WebPageCreationParameters
shouldn't need any further modifications.

* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
The SubframeProcessPageParameters struct definition has been moved outside
of WebPageCreationParameters, so that a forward declaration is enough when
declaring WebPageProxy::creationParameters.

* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::creationParametersForProvisionalPage):
(WebKit::WebPageProxy::creationParametersForRemotePage):
Added new function parameters, as needed for provisional and remote pages,
and helper functions that only take the minimum required parameters.

* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::initializeWebPage):
Using the updated WebPageProxy::creationParameters function.
Since it doesn't require doctoring, it can be used directly in the
message creation.
Also, the call may be delayed until & if it is actually needed.

* Source/WebKit/UIProcess/RemotePageProxy.cpp:
(WebKit::RemotePageProxy::injectPageIntoNewProcess):
Using the updated WebPageProxy::creationParameters function.
Since it doesn't require doctoring, it can be used directly in the
message creation.

Canonical link: https://commits.webkit.org/275251@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications