[webkit-changes] [WebKit/WebKit] 33172d: getOutputTimestamp() seems to use wrong time scale

Chris Dumez noreply at github.com
Fri Feb 23 07:59:38 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 33172dfe163a1a3445e76b23bc9a9b705516fc11
      https://github.com/WebKit/WebKit/commit/33172dfe163a1a3445e76b23bc9a9b705516fc11
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    A LayoutTests/webaudio/getOutputTimestamp-expected.txt
    A LayoutTests/webaudio/getOutputTimestamp.html
    M Source/WebCore/platform/audio/AudioDestinationResampler.cpp

  Log Message:
  -----------
  getOutputTimestamp() seems to use wrong time scale
https://bugs.webkit.org/show_bug.cgi?id=264247
rdar://118323705

Reviewed by Eric Carlson.

The time returned by getOutputTimestamp() was incorrectly divided by the
sample rate. Fix this so the value returned is correct and matches Chrome
and Firefox.

* LayoutTests/webaudio/getOutputTimestamp-expected.txt: Added.
* LayoutTests/webaudio/getOutputTimestamp.html: Added.
* Source/WebCore/platform/audio/AudioDestinationResampler.cpp:
(WebCore::AudioDestinationResampler::render):

Canonical link: https://commits.webkit.org/275237@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list