[webkit-changes] [WebKit/WebKit] c67d58: Pause control does not work in in-window mode

Dana Estra noreply at github.com
Fri Feb 23 02:17:45 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c67d585912b331ac7757866a1f969e25de04553c
      https://github.com/WebKit/WebKit/commit/c67d585912b331ac7757866a1f969e25de04553c
  Author: Dana Estra <destra at apple.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/button.js

  Log Message:
  -----------
  Pause control does not work in in-window mode
https://bugs.webkit.org/show_bug.cgi?id=269951
rdar://122834226

Reviewed by Jer Noble.

This bug was caused by both our event handler for clicking on the pause button
and youtube's event handler for clicking on the video both being activated,
causing the video to pause and then immediately be played again. To prevent
this, in our button's event handler we now call stopPropagation().

* Source/WebCore/Modules/modern-media-controls/controls/button.js:
(Button.prototype.handleEvent):

Canonical link: https://commits.webkit.org/275229@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list