[webkit-changes] [WebKit/WebKit] 9a1d1c: HTMLDataListElement::childrenChanged doesn't call ...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a1d1c7db2182ce4eab131e2cdcc55a9995b4351
      https://github.com/WebKit/WebKit/commit/9a1d1c7db2182ce4eab131e2cdcc55a9995b4351
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    A LayoutTests/fast/dom/datalist-children-changed-crash-expected.txt
    A LayoutTests/fast/dom/datalist-children-changed-crash.html
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/html/HTMLDataListElement.cpp

  Log Message:
  -----------
  HTMLDataListElement::childrenChanged doesn't call HTMLElement::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=269959
<rdar://123388053>

Reviewed by Chris Dumez.

This can lead to an inconsistent state in DOM so call that.

* LayoutTests/fast/dom/datalist-children-changed-crash-expected.txt: Added.
* LayoutTests/fast/dom/datalist-children-changed-crash.html: Added.
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion): Added a debug
assertion to catch a similar mistake in the future.
* Source/WebCore/html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::childrenChanged):

Canonical link: https://commits.webkit.org/275221@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications