[webkit-changes] [WebKit/WebKit] 467125: REGRESSION(274325 at main): Find matches can not be s...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 467125332e143e71f853f6c873f2087d248bdf60
      https://github.com/WebKit/WebKit/commit/467125332e143e71f853f6c873f2087d248bdf60
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/FindController.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm

  Log Message:
  -----------
  REGRESSION(274325 at main): Find matches can not be selected after calling `findMatchesForString`
https://bugs.webkit.org/show_bug.cgi?id=269825
rdar://123465751

Reviewed by Aditya Keerthi.

Before 274325 at main, `FindController::updateFindUIAfterPageScroll` would clear `m_findMatches` only if it
was called from `FindController::findString`. After 274325 at main, all call sites will clear it, so a
client will not be able to set selection after calling `findMatchesForString`. To match the previous
behavior we can check if a frame identifier was passed, since that will only be provided by
`FindController::findString`.

* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST):

Canonical link: https://commits.webkit.org/275219@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications