[webkit-changes] [WebKit/WebKit] 73bf87: REGRESSION(274853 at main): [WPE][GTK][Debug] ASSERTI...

[Vitaly Dyachkov]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 73bf87126bb540ddfe001061821e93c0e3a78fdf
      https://github.com/WebKit/WebKit/commit/73bf87126bb540ddfe001061821e93c0e3a78fdf
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/ManagedMediaSource.idl
    M Source/WebCore/Modules/mediasource/MediaSource.idl
    M Source/WebCore/Modules/mediasource/SourceBuffer.idl
    M Source/WebCore/bindings/scripts/preprocess-idls.pl

  Log Message:
  -----------
  REGRESSION(274853 at main): [WPE][GTK][Debug] ASSERTION FAILED: context.isDocument()
https://bugs.webkit.org/show_bug.cgi?id=269912

Reviewed by Chris Dumez.

Starting from 274853 at main, we allow `MediaSource` to be constructed in
a `DedicatedWorker` but only if `MEDIA_SOURCE_IN_WORKERS` is enabled.

We should enforce this requirement in `MediaSource.idl` using
`ConditionalForWorker` extended attribute to ensure that its constructor
will not be exposed on worker.
The same applies to `Managed Media Source` and `Source Buffer`.

We also must make `preprocess-idls.pl` to check this condition not only
for `Worker` but also for `DedicatedWorker` global context.

* Source/WebCore/Modules/mediasource/ManagedMediaSource.idl:
* Source/WebCore/Modules/mediasource/MediaSource.idl:
* Source/WebCore/Modules/mediasource/SourceBuffer.idl:
* Source/WebCore/bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttributes):

Canonical link: https://commits.webkit.org/275188@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications