[webkit-changes] [WebKit/WebKit] 2ccf91: [Cocoa] Enable reordering size computation for ann...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2ccf91f163fb0909f092aafd36f8d8cbe6d74a3f
      https://github.com/WebKit/WebKit/commit/2ccf91f163fb0909f092aafd36f8d8cbe6d74a3f
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    A LayoutTests/http/tests/webcodecs/h264-reordering-annexB-expected.txt
    A LayoutTests/http/tests/webcodecs/h264-reordering-annexB.html
    A LayoutTests/http/tests/webcodecs/hevc-reordering-annexB-expected.txt
    A LayoutTests/http/tests/webcodecs/hevc-reordering-annexB.html
    A LayoutTests/media/media-source/content/test-bframes-hevc.mp4.annexb
    A LayoutTests/media/media-source/content/test-fragmented.mp4.annexb
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm
    M Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc

  Log Message:
  -----------
  [Cocoa] Enable reordering size computation for annexB H264 and H265 decoders
rdar://122902399
https://bugs.webkit.org/show_bug.cgi?id=269462

Reviewed by Eric Carlson.

The SPS parser is starting after the NALU header and not at the NALU directly.
We offset by 1 for H264 and by 2 for H265 as per spec.

We also need to do this parsing only for annexB and not AVC/HEVC formats.
Minor cleanup to rename _useAVC by _useHEVC in RTCVideoDecoderH265.

Covered by added tests.

* LayoutTests/http/tests/webcodecs/h264-reordering-annexB-expected.txt: Added.
* LayoutTests/http/tests/webcodecs/h264-reordering-annexB.html: Added.
* LayoutTests/http/tests/webcodecs/hevc-reordering-annexB-expected.txt: Added.
* LayoutTests/http/tests/webcodecs/hevc-reordering-annexB.html: Added.
* LayoutTests/media/media-source/content/test-bframes-hevc.mp4.annexb: Added.
* LayoutTests/media/media-source/content/test-fragmented.mp4.annexb: Added.
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH264.mm:
(-[RTCVideoDecoderH264 decodeData:size:timeStamp:]):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderH265.mm:
(ComputeH265ReorderSizeFromAnnexB):
(-[RTCVideoDecoderH265 init]):
(-[RTCVideoDecoderH265 decodeData:size:timeStamp:]):
(-[RTCVideoDecoderH265 setHVCCFormat:size:width:height:]):
* Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/nalu_rewriter.cc:

Canonical link: https://commits.webkit.org/275173@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications