[webkit-changes] [WebKit/WebKit] 21530f: DisplayList replay does not apply filters

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21530f9cc92c09f19c293d2943fea77f31358b98
      https://github.com/WebKit/WebKit/commit/21530f9cc92c09f19c293d2943fea77f31358b98
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp
    M Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp
    M Source/WebCore/platform/graphics/displaylists/DisplayListItems.h

  Log Message:
  -----------
  DisplayList replay does not apply filters
https://bugs.webkit.org/show_bug.cgi?id=269738

Reviewed by Said Abou-Hallawa.

DisplayList recording properly handles filters -- they
are serialized as 'DrawFilteredImageBuffer' command. During replay this
display list item type is unhandled, therefore the filtered image is not
drawn when replaying the display list - fix that.

This blocks the intrduction of the multi-threaded CPU rendering mode
for WPE/Skia, since that relies on DisplayList recording & replay.

Coverered by existing tests, when enforcing DisplayList recording.

* Source/WebCore/platform/graphics/displaylists/DisplayListItem.cpp:
(WebCore::DisplayList::applyFilteredImageBufferItem):
(WebCore::DisplayList::applyItem):
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawFilteredImageBuffer::apply const):
(WebCore::DisplayList::DrawFilteredImageBuffer::apply): Deleted.
* Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:

Canonical link: https://commits.webkit.org/275163@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications