[webkit-changes] [WebKit/WebKit] 44326f: [view-transitions] Clean-up outdated FIXMEs

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44326f5d96d5185d80c41681abe2441811990728
      https://github.com/WebKit/WebKit/commit/44326f5d96d5185d80c41681abe2441811990728
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-02-22 (Thu, 22 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderLayerCompositor.cpp

  Log Message:
  -----------
  [view-transitions] Clean-up outdated FIXMEs
https://bugs.webkit.org/show_bug.cgi?id=269899
rdar://123427127

Reviewed by Matt Woodrow.

- Remove outdated FIXMEs for dynamic view transition stylesheet
- Re-order steps in dynamic view transition stylesheet to match spec
- Rename RenderElement::hasViewTransition to RenderElement::capturedInViewTransition to match spec terminology
- Remove FIXME for "captured in view transition" node flag. It's only used in the spec to store eligibility for a capture,
which can be cheaply computed if ever needed in the future.

* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::setupDynamicStyleSheet):
(WebCore::ViewTransition::activateViewTransition):
(WebCore::ViewTransition::clearViewTransition):
* Source/WebCore/dom/ViewTransition.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::requiresLayer const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::capturedInViewTransition const):
(WebCore::RenderElement::hasViewTransition const): Deleted.
* Source/WebCore/rendering/RenderElement.h:
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::computeCanBeBackdropRoot const):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::requiresCompositingForViewTransition const):

Canonical link: https://commits.webkit.org/275161@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications