[webkit-changes] [WebKit/WebKit] 27713e: [WebKitSwift] Add a target dependency on WebKit

Wenson Hsieh noreply at github.com
Wed Feb 21 23:18:54 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27713ed79eddae10b8e98de95a1aa8a34b9cdadb
      https://github.com/WebKit/WebKit/commit/27713ed79eddae10b8e98de95a1aa8a34b9cdadb
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [WebKitSwift] Add a target dependency on WebKit
https://bugs.webkit.org/show_bug.cgi?id=269879

Reviewed by Andy Estes.

Make WebKitSwift depend on WebKit. The new logic in `WKWebView+TextExtraction.swift` will require
importing the WebKit module from within WebKitSwift, which requires the WebKit build to be finished
first. With the changes in 275053 at main, WebKit no longer depends on WebKitSwift's umbrella header,
so it's now safe to simply add this target dependency.

Without this change, engineering builds that enable the build-time flags within
`WKWebView+TextExtraction.swift` may sporadically fail when building WebKit.

* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/275154@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list