[webkit-changes] [WebKit/WebKit] 35cfdf: setupTransitionPseudoElements doesn't update the v...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 35cfdf3fdab6aa072eb6203618c0f7b6189aab66
      https://github.com/WebKit/WebKit/commit/35cfdf3fdab6aa072eb6203618c0f7b6189aab66
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/group-animation-for-root-transition-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/mix-blend-mode-only-on-transition-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/paused-animation-at-end-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/synchronous-callback-skipped-before-run-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h
    M Source/WebCore/style/StyleResolver.cpp
    M Source/WebCore/style/StyleResolver.h

  Log Message:
  -----------
  setupTransitionPseudoElements doesn't update the view transition dynamic style sheet.
https://bugs.webkit.org/show_bug.cgi?id=265225
<rdar://118703381>

Reviewed by Tim Nguyen.

Refactors Resolver::setViewTransitionGroupStyle to take the pseduo element type,
and builds the appropriate selector, so that it can be used for all view-transition
pseudo elements.

Adds the generation of the view-transition dynamic style sheet styles to
ViewTransition::setupTransitionPseudoElements.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/mix-blend-mode-only-on-transition-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/paused-animation-at-end-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/unset-and-initial-view-transition-name-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/view-transition-name-on-removed-element-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/window-resize-aborts-transition-expected.txt:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupDynamicStyleSheet):
(WebCore::ViewTransition::setupTransitionPseudoElements):
(WebCore::ViewTransition::copyElementBaseProperties):
(WebCore::ViewTransition::updatePseudoElementStyles):
* Source/WebCore/dom/ViewTransition.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::viewTransitionSelector):
(WebCore::Style::Resolver::setViewTransitionStyles):
(WebCore::Style::Resolver::setViewTransitionGroupStyles): Deleted.
* Source/WebCore/style/StyleResolver.h:

Canonical link: https://commits.webkit.org/275144@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications