[webkit-changes] [WebKit/WebKit] e1cab3: Generate serialization of NSURLCredential

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1cab360c28ad35642b685bd17a9d3db6a052121
      https://github.com/WebKit/WebKit/commit/e1cab360c28ad35642b685bd17a9d3db6a052121
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebKit/DerivedSources-input.xcfilelist
    M Source/WebKit/DerivedSources.make
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm
    A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h
    A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm
    A Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm

  Log Message:
  -----------
  Generate serialization of NSURLCredential
https://bugs.webkit.org/show_bug.cgi?id=269651

Reviewed by Pascoe.

There's still work to be done to expose exactly what this dictionary should look like
in SerializedTypeInfo.mm somehow, but at least we're not using SecureCoding any more.
This is a baby step in the right direction.

This works on all platforms except macOS Monterey, which doesn't use
_enableStrictSecureDecodingMode for all types anyways, so on Monterey only, just use
NSKeyedUnarchiver.  Monterey also doesn't have the ability to serialize NSURLCredentials
with identities in them.  The Monterey code will be removed soon.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::encodeObjectDirectly<NSObject<NSSecureCoding>>):
(IPC::shouldEnableStrictMode):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.h: Added.
(WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm: Added.
(WebKit::CoreIPCNSURLCredential::CoreIPCNSURLCredential):
(WebKit::CoreIPCNSURLCredential::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.serialization.in: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(NSURLCredentialTesting_isEqual):
(operator==):
(TEST):

Canonical link: https://commits.webkit.org/275132@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications