[webkit-changes] [WebKit/WebKit] ce4726: [view-transitions] Support style inheritance in th...

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce47267f2d5ecaa5aefd2346a8cfa59b7aaeb08a
      https://github.com/WebKit/WebKit/commit/ce47267f2d5ecaa5aefd2346a8cfa59b7aaeb08a
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/rendering/style/RenderStyleSetters.h
    M Source/WebCore/style/StyleTreeResolver.cpp

  Log Message:
  -----------
  [view-transitions] Support style inheritance in the pseudo-element tree
https://bugs.webkit.org/show_bug.cgi?id=269808
rdar://123331760

Reviewed by Anne van Kesteren.

The style inheritance must follow the pseudo-element tree structure. This allows the different `inherit` declarations in the `viewTransitions.css` UA stylesheet to work.

This is also ergonomic for developers since they can just set the animation-duration once and have it cascade down the pseudo-element tree.

Also fix the cache to actually store the named view transition style when resolving, otherwise `TreeResolver::makeResolutionContextForPseudoElement` can't fetch it.

* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt: Rebaselined test.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::resolvePseudoElementStyle):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setPseudoElementNameArgument):
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement):

Canonical link: https://commits.webkit.org/275121@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications