[webkit-changes] [WebKit/WebKit] c443c9: Fix custom/pattern-userSpaceOnUse-userToBaseTransf...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c443c971c715d48e5b9031f62c0926d05f27310c
      https://github.com/WebKit/WebKit/commit/c443c971c715d48e5b9031f62c0926d05f27310c
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    A LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt
    A LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt
    M LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations
    A LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt
    A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png
    A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt
    A LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml
    M Source/WebCore/rendering/RenderLayer.cpp
    M Source/WebCore/rendering/RenderLayer.h

  Log Message:
  -----------
  Fix custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
https://bugs.webkit.org/show_bug.cgi?id=269234

Reviewed by Nikolas Zimmermann.

When determining RenderSVGRoot as root layer we also calculate
any padding/border values as part of offsetFromAncestor, this
means for patterns painting would be wrongly offset for pattern
content. Instead, use the RenderSVGRoot, viewport as root layer
which discards any border/padding for the pattern content painting.

* LayoutTests/platform/glib/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added.
* LayoutTests/platform/ios/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added.
* LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations:
* LayoutTests/platform/mac-sonoma-wk2-lbse-text/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added.
* LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.png: Added.
* LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox-expected.txt: Added.
* LayoutTests/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-with-viewBox.xhtml: Added.
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintSVGResourceLayer):
(WebCore::RenderLayer::enclosingSVGRootLayer const): Deleted.
* Source/WebCore/rendering/RenderLayer.h:

Canonical link: https://commits.webkit.org/275117@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications