[webkit-changes] [WebKit/WebKit] 3fc817: [WebGPU] Buffer index is not validated prior to me...

mwyrzykowski noreply at github.com
Wed Feb 21 10:45:19 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fc81749e677cd4cd339c89b7cf3145c2972ea59
      https://github.com/WebKit/WebKit/commit/3fc81749e677cd4cd339c89b7cf3145c2972ea59
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.h
    M Source/WebGPU/WGSL/WGSL.cpp

  Log Message:
  -----------
  [WebGPU] Buffer index is not validated prior to metal compilation
https://bugs.webkit.org/show_bug.cgi?id=269821
<radar://123322561>

Reviewed by Dan Glastonbury.

WGSL allows any buffer to be used, but we need to fail
pipeline creation if the buffer index in the WGSL is too
large.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::RewriteGlobalVariables):
(WGSL::RewriteGlobalVariables::run):
(WGSL::buffersForStage):
(WGSL::RewriteGlobalVariables::collectGlobals):
(WGSL::rewriteGlobalVariables):
* Source/WebGPU/WGSL/GlobalVariableRewriter.h:
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepareImpl):

Canonical link: https://commits.webkit.org/275112@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list