[webkit-changes] [WebKit/WebKit] 7839f9: [CSS Container Queries][Style queries] Allow !impo...

[Antti Koivisto]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7839f9caaeec6540011d7470842f0966773b92a1
      https://github.com/WebKit/WebKit/commit/7839f9caaeec6540011d7470842f0966773b92a1
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-02-21 (Wed, 21 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-style-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/CSSParserImpl.h
    M Source/WebCore/css/parser/CSSParserTokenRange.cpp
    M Source/WebCore/css/parser/CSSParserTokenRange.h
    M Source/WebCore/css/query/GenericMediaQueryParser.cpp

  Log Message:
  -----------
  [CSS Container Queries][Style queries] Allow !important
https://bugs.webkit.org/show_bug.cgi?id=269844
rdar://123374708

Reviewed by Alan Baradlay.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt:
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeTrailingImportantAndWhitespace):

Factor into a function and clean up.

(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::removeTrailingWhitespace): Deleted.
* Source/WebCore/css/parser/CSSParserImpl.h:
* Source/WebCore/css/parser/CSSParserTokenRange.cpp:
(WebCore::CSSParserTokenRange::trimTrailingWhitespace):
(WebCore::CSSParserTokenRange::consumeLast):
(WebCore::CSSParserTokenRange::consumeAllExcludingTrailingWhitespace): Deleted.

Some helper improvements.

* Source/WebCore/css/parser/CSSParserTokenRange.h:
(WebCore::CSSParserTokenRange::consumeAll):
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
(WebCore::MQ::consumeCustomPropertyValue):

Consume away any !important and proceed to ignore it.

Canonical link: https://commits.webkit.org/275104@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications