[webkit-changes] [WebKit/WebKit] 65d5c8: MacCatalyst engineering build is broken on ToT for...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65d5c80e4e183ab1f41152388e975fdd33cbe259
      https://github.com/WebKit/WebKit/commit/65d5c80e4e183ab1f41152388e975fdd33cbe259
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/dom/Document.cpp
    M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
    M Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd

  Log Message:
  -----------
  MacCatalyst engineering build is broken on ToT for various reasons
https://bugs.webkit.org/show_bug.cgi?id=269812
rdar://123333483

Reviewed by Alexey Proskuryakov and Wenson Hsieh.

This patch makes an assortment of build fixes for the MacCatalyst
engineering build, namely:

- In IPCSerialization API tests, make sure to not call SecTrust API that
  is unavailable in the MacCatalyst SDK.
- In the WebCore::Document constructor, call ASSERT(!m_fullscreenManager)
  only when the Fullscreen API is enabled.
- Add MacCatalyst to the target set in libTestWTFAlwaysMissing-iOS.tbd,
  otherwise TestWTF linking fails.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::m_frameIdentifier):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(secTrustRefsEqual):
* Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:

Canonical link: https://commits.webkit.org/275086@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications