[webkit-changes] [WebKit/WebKit] 142e54: ::view-transition-group dynamic styles doesn't com...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 142e5436fbfb59ae112dda82b4580a33fa6bec73
      https://github.com/WebKit/WebKit/commit/142e5436fbfb59ae112dda82b4580a33fa6bec73
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/ComputedStyleExtractor.h
    M Source/WebCore/dom/ViewTransition.cpp

  Log Message:
  -----------
  ::view-transition-group dynamic styles doesn't compute the transform.
https://bugs.webkit.org/show_bug.cgi?id=269692
<rdar://123213197>

Reviewed by Tim Nguyen.

The dynamically computed style for :root::view-transition-group(transitionName)
should include 'a transform that would map capturedElement’s new element's
border box from the snapshot containing block origin to its current visual
position.'

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::matrixTransformValue):
(WebCore::transformOperationAsCSSValue):
(WebCore::computedTransform):
(WebCore::matrixTransformValue): Deleted.
* Source/WebCore/css/ComputedStyleExtractor.h:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::copyElementBaseProperties):

Canonical link: https://commits.webkit.org/275080@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications