[webkit-changes] [WebKit/WebKit] 607817: Remove browser.test.testEvent and browser.test.fir...

Timothy Hatcher noreply at github.com
Tue Feb 20 14:21:23 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 607817d6a54bd5803b8a719493511a70034a533e
      https://github.com/WebKit/WebKit/commit/607817d6a54bd5803b8a719493511a70034a533e
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm
    M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h
    M Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIEvent.mm

  Log Message:
  -----------
  Remove browser.test.testEvent and browser.test.fireTestEvent().
https://webkit.org/b/269659
rdar://123173676

Reviewed by Brian Weinstein.

* Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITestCocoa.mm:
(WebKit::WebExtensionAPITest::testEvent): Deleted.
(WebKit::WebExtensionAPITest::fireTestEvent): Deleted.
* Source/WebKit/WebProcess/Extensions/API/WebExtensionAPITest.h:
* Source/WebKit/WebProcess/Extensions/Interfaces/WebExtensionAPITest.idl:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIEvent.mm:
(TEST(WKWebExtensionAPIEvent, Errors)): Use browser.runtime.onStartup instead.
(TEST(WKWebExtensionAPIEvent, TestEventListener)): Ditto. Firing events is
tested plenty of times in other tests.

Canonical link: https://commits.webkit.org/275071@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list