[webkit-changes] [WebKit/WebKit] a6fdfb: [JSC] Add missed "cc" inline asm clobber to ARM64 ...

Kristina Bessonova noreply at github.com
Tue Feb 20 11:24:43 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6fdfba9ecedf5bd261c65fda1de8c795dc6a053
      https://github.com/WebKit/WebKit/commit/a6fdfba9ecedf5bd261c65fda1de8c795dc6a053
  Author: Kristina Bessonova <kbessonova at accesssoftek.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/GCMemoryOperations.h

  Log Message:
  -----------
  [JSC] Add missed "cc" inline asm clobber to ARM64 memory operations
https://bugs.webkit.org/show_bug.cgi?id=269785

Reviewed by Keith Miller.

Since inline asm touches flags, it should set "cc" clobber to ensure
a compiler will schedule instructions correctly.

W/o the clobber and if compiled with clang v16 and newer (AArch64,
Linux) may lead to a crash inside JSArray::unshiftCountSlowCase().

* Source/JavaScriptCore/heap/GCMemoryOperations.h:
(JSC::gcSafeMemcpy):
(JSC::gcSafeMemmove):
(JSC::gcSafeZeroMemory):

Canonical link: https://commits.webkit.org/275057@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list