[webkit-changes] [WebKit/WebKit] ce8807: [WGSL] Failed concretization generates invalid types

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ce88073de78f1edecd17a089451523034ffba6ac
      https://github.com/WebKit/WebKit/commit/ce88073de78f1edecd17a089451523034ffba6ac
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-02-20 (Tue, 20 Feb 2024)

  Changed paths:
    M Source/WebGPU/WGSL/Constraints.cpp
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] Failed concretization generates invalid types
https://bugs.webkit.org/show_bug.cgi?id=269720
rdar://123238768

Reviewed by Mike Wyrzykowski.

`concretize` might return a nullptr if the type can't be concretized, so recursive
calls need to check the result before constructing the return type, otherwise it
can result in e.g. a vector with a nullptr element.

* Source/WebGPU/WGSL/Constraints.cpp:
(WGSL::concretize):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):

Canonical link: https://commits.webkit.org/275040@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications