[webkit-changes] [WebKit/WebKit] 453410: [WebGPU] GPUDevice::destroy deference deallocated ...

mwyrzykowski noreply at github.com
Mon Feb 19 23:47:55 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 453410211ed24fa7155e7f34fedfcaf0bb958911
      https://github.com/WebKit/WebKit/commit/453410211ed24fa7155e7f34fedfcaf0bb958911
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-19 (Mon, 19 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/GPUBuffer.h
    M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
    M Source/WebCore/Modules/WebGPU/GPUDevice.h

  Log Message:
  -----------
  [WebGPU] GPUDevice::destroy deference deallocated GPUBuffer instances
https://bugs.webkit.org/show_bug.cgi?id=269741
<radar://123051116>

Reviewed by Dan Glastonbury.

Use WeakHashSet instead of HashSet since some GPUBuffers
may be destroyed / deallocated before the device is destroyed.

* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::addBufferToUnmap):
(WebCore::GPUDevice::removeBufferToUnmap):
(WebCore::GPUDevice::destroy):
* Source/WebCore/Modules/WebGPU/GPUDevice.h:

Canonical link: https://commits.webkit.org/275027@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list