[webkit-changes] [WebKit/WebKit] e391cf: Move parsePseudoElement() to CSSSelectorParser

Anne van Kesteren noreply at github.com
Mon Feb 19 22:04:21 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e391cfe1f5053d5d19adcdfdc86da75aec4ba0df
      https://github.com/WebKit/WebKit/commit/e391cfe1f5053d5d19adcdfdc86da75aec4ba0df
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-02-19 (Mon, 19 Feb 2024)

  Changed paths:
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.h
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  Move parsePseudoElement() to CSSSelectorParser
https://bugs.webkit.org/show_bug.cgi?id=269597
rdar://123120827

Reviewed by Tim Nguyen.

This originally landed as 274893 at main but got backed out as collateral
damage in 274996 at main. The main change is that now it's being moved
before the PseudoElementIdentifier dependency is added. That will be
done on top of this change in bug 264103.

The motivation for moving this hasn't changed: CSSSelector shouldn't
contain parser code.

* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::pseudoIdFromString):
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::parsePseudoElement): Deleted.
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::parsePseudoElement):
* Source/WebCore/css/parser/CSSSelectorParser.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::getComputedStyle const):
(WebCore::LocalDOMWindow::getMatchedCSSRules const):

Canonical link: https://commits.webkit.org/275022@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list