[webkit-changes] [WebKit/WebKit] 393573: HTMLPreloadScanner should only use valid `base` urls

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 393573035d7ef055e27d29da79d2f8ce5833f783
      https://github.com/WebKit/WebKit/commit/393573035d7ef055e27d29da79d2f8ce5833f783
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-02-19 (Mon, 19 Feb 2024)

  Changed paths:
    A LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt
    A LayoutTests/fast/parser/badurl-base-preloader-crash.html
    A LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt
    A LayoutTests/http/tests/loading/preload-ignore-invalid-base.html
    A LayoutTests/http/tests/loading/resources/fail.js
    M Source/WebCore/html/parser/HTMLPreloadScanner.cpp

  Log Message:
  -----------
  HTMLPreloadScanner should only use valid `base` urls

https://bugs.webkit.org/show_bug.cgi?id=269643

Reviewed by Ryosuke Niwa.

Partial Merge: https://chromium.googlesource.com/chromium/blink/+/754b22f62f6fa5f0b938a90c0e92502eb7f5a7c3

Before this patch, HTMLPreloadScanner accepted invalid `base` urls and
used it to resolve urls encountered later in the scan.
This patch ensures that only valid urls specified in `base href` are
actually used as base urls.

* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(TokenPreloadScanner::updatePredictedBaseURL):
* LayoutTests/fast/parser/badurl-base-preloader-crash.html: Add Test Case
* LayoutTests/fast/parser/badurl-base-preloader-crash-expected.txt: Add Test Case Expectation
* LayoutTests/http/tests/loading/preload-ignore-invalid-base.html: Add Test Case
* LayoutTests/http/tests/loading/resources/fail.js: Add Test Case Helper Script
* LayoutTests/http/tests/loading/preload-ignore-invalid-base-expected.txt: Add Test Expectation

Canonical link: https://commits.webkit.org/274963@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications