[webkit-changes] [WebKit/WebKit] fd1700: [view-transitions] Support script-originated anima...

Tim Nguyen noreply at github.com
Sun Feb 18 22:33:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd1700a9494c4ead2a8d7add78378403081646b7
      https://github.com/WebKit/WebKit/commit/fd1700a9494c4ead2a8d7add78378403081646b7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2024-02-18 (Sun, 18 Feb 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/web-animation-pseudo-incorrect-name-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp
    M Source/WebCore/animation/WebAnimationUtilities.cpp
    M Source/WebCore/animation/WebAnimationUtilities.h

  Log Message:
  -----------
  [view-transitions] Support script-originated animations
https://bugs.webkit.org/show_bug.cgi?id=269468
rdar://123016183

Reviewed by Matt Woodrow and Matthieu Dubet.

- Switch to use pseudoElementIdentifier in order to support view transition pseudo-elements
- Pass in a document to the relevant CSSSelectorParserContext so the view transition setting state is passed over

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/pseudo-get-computed-style.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/web-animation-pseudo-incorrect-name-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::pseudoElement const):
(WebCore::KeyframeEffect::setPseudoElement):
* Source/WebCore/animation/StyleOriginatedAnimationEvent.cpp:
(WebCore::StyleOriginatedAnimationEvent::StyleOriginatedAnimationEvent):
(WebCore::StyleOriginatedAnimationEvent::pseudoElement):
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::pseudoElementIdentifierAsString):
(WebCore::pseudoElementIdentifierFromString):
(WebCore::pseudoIdAsString): Deleted.
(WebCore::pseudoIdFromString): Deleted.
* Source/WebCore/animation/WebAnimationUtilities.h:

Canonical link: https://commits.webkit.org/274961@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list