[webkit-changes] [WebKit/WebKit] b1c316: Invokers should work on non-html elements

[Luke Warlow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b1c3165a6c3bfac437737539fdbc51cfb395dbae
      https://github.com/WebKit/WebKit/commit/b1c3165a6c3bfac437737539fdbc51cfb395dbae
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-02-18 (Sun, 18 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/HTMLElement.h
    M Source/WebCore/html/HTMLFormControlElement.cpp
    M Source/WebCore/html/HTMLFormControlElement.h

  Log Message:
  -----------
  Invokers should work on non-html elements
https://bugs.webkit.org/show_bug.cgi?id=269673

Reviewed by Tim Nguyen.

This changes invokers to work on non-HTML elements by changing code to reference Element instead of HTMLElement.

This patch also fixes the relevant test as it was wrong.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html:
* Source/WebCore/dom/Element.h:
(WebCore::Element::handleInvokeInternal):
* Source/WebCore/html/HTMLElement.h:
(WebCore::HTMLElement::handleInvokeInternal): Deleted.
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::invokeTargetElement const):
* Source/WebCore/html/HTMLFormControlElement.h:

Canonical link: https://commits.webkit.org/274954@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications