[webkit-changes] [WebKit/WebKit] 1fcbc1: Remove local `track` tests in favor of WPT

Ahmad Saleem noreply at github.com
Sun Feb 18 07:42:47 PST 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fcbc136b4143a32dca6429fa0679c24cd41e763
      https://github.com/WebKit/WebKit/commit/1fcbc136b4143a32dca6429fa0679c24cd41e763
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-02-18 (Sun, 18 Feb 2024)

  Changed paths:
    R LayoutTests/media/track/captions-webvtt/cues-chrono-order.vtt
    R LayoutTests/media/track/captions-webvtt/tc001-iso2022jp3.vtt
    R LayoutTests/media/track/captions-webvtt/tc001-utf8.vtt
    R LayoutTests/media/track/captions-webvtt/tc002-bom.vtt
    R LayoutTests/media/track/captions-webvtt/tc003-newlines.vtt
    R LayoutTests/media/track/captions-webvtt/tc003-no-newline-at-eof.vtt
    R LayoutTests/media/track/captions-webvtt/tc004-webvtt-rubbish.vtt
    R LayoutTests/media/track/captions-webvtt/tc005-metadata-area.vtt
    R LayoutTests/media/track/captions-webvtt/tc006-cue-id-error.vtt
    R LayoutTests/media/track/captions-webvtt/tc006-cue-id.vtt
    R LayoutTests/media/track/captions-webvtt/tc007-cue-no-id-error.vtt
    R LayoutTests/media/track/captions-webvtt/tc007-cue-no-id.vtt
    R LayoutTests/media/track/captions-webvtt/tc008-timings-no-hour-errors.vtt
    R LayoutTests/media/track/captions-webvtt/tc008-timings-no-hour.vtt
    R LayoutTests/media/track/captions-webvtt/tc009-timings-hour-error.vtt
    R LayoutTests/media/track/captions-webvtt/tc009-timings-hour.vtt
    R LayoutTests/media/track/captions-webvtt/tc010-no-timings.vtt
    R LayoutTests/media/track/captions-webvtt/tc011-cues-no-separation.vtt
    R LayoutTests/media/track/captions-webvtt/tc011-cues.vtt
    R LayoutTests/media/track/captions-webvtt/tc012-out-of-order.vtt
    R LayoutTests/media/track/captions-webvtt/tc013-settings-bad-separation.vtt
    R LayoutTests/media/track/captions-webvtt/tc014-alignment-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc014-alignment-ltr.vtt
    R LayoutTests/media/track/captions-webvtt/tc014-alignment.vtt
    R LayoutTests/media/track/captions-webvtt/tc015-positioning-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc015-positioning-ltr.vtt
    R LayoutTests/media/track/captions-webvtt/tc015-positioning.vtt
    R LayoutTests/media/track/captions-webvtt/tc016-align-positioning-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc016-align-positioning.vtt
    R LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc017-line-position.vtt
    R LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc018-align-text-line-position.vtt
    R LayoutTests/media/track/captions-webvtt/tc020-cue-size-align-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc020-cue-size-align.vtt
    R LayoutTests/media/track/captions-webvtt/tc021-valign-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc021-valign-ltr.vtt
    R LayoutTests/media/track/captions-webvtt/tc021-valign.vtt
    R LayoutTests/media/track/captions-webvtt/tc022-entities-wrong.vtt
    R LayoutTests/media/track/captions-webvtt/tc022-entities.vtt
    R LayoutTests/media/track/captions-webvtt/tc023-markup-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc023-markup.vtt
    R LayoutTests/media/track/captions-webvtt/tc024-timestamp-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc024-timestamp.vtt
    R LayoutTests/media/track/captions-webvtt/tc025-class-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc025-class.vtt
    R LayoutTests/media/track/captions-webvtt/tc026-voice-bad.vtt
    R LayoutTests/media/track/captions-webvtt/tc026-voice.vtt
    R LayoutTests/media/track/captions-webvtt/tc027-empty-cue.vtt
    R LayoutTests/media/track/captions-webvtt/tc028-unsupported-markup.vtt
    R LayoutTests/media/track/captions-webvtt/tc029-timings-whitespace.vtt
    R LayoutTests/media/track/captions-webvtt/tc030-interspersed-non-cue.vtt
    R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-cuetext.vtt
    R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-header.vtt
    R LayoutTests/media/track/captions-webvtt/tc031-cue-recovery-note.vtt
    R LayoutTests/media/track/captions-webvtt/tc032-degenerate-cues.vtt
    R LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html
    R LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLTrackElement/kind.html
    R LayoutTests/media/track/regions-webvtt/vtt-region-parser-expected.txt
    R LayoutTests/media/track/regions-webvtt/vtt-region-parser.html
    R LayoutTests/media/track/track-active-cues-expected.txt
    R LayoutTests/media/track/track-active-cues.html
    R LayoutTests/media/track/track-constants-expected.txt
    R LayoutTests/media/track/track-constants.html
    R LayoutTests/media/track/track-cues-cuechange-expected.txt
    R LayoutTests/media/track/track-cues-cuechange.html
    R LayoutTests/media/track/track-cues-enter-exit-expected.txt
    R LayoutTests/media/track/track-cues-enter-exit.html
    R LayoutTests/media/track/track-node-add-remove-expected.txt
    R LayoutTests/media/track/track-node-add-remove.html
    R LayoutTests/media/track/track-remove-active-cue-crash-expected.txt
    R LayoutTests/media/track/track-remove-active-cue-crash.html
    R LayoutTests/media/track/track-remove-track-expected.txt
    R LayoutTests/media/track/track-remove-track.html
    R LayoutTests/media/track/track-webvtt-tc001-utf8-expected.txt
    R LayoutTests/media/track/track-webvtt-tc001-utf8.html
    R LayoutTests/media/track/track-webvtt-tc002-bom-expected.txt
    R LayoutTests/media/track/track-webvtt-tc002-bom.html
    R LayoutTests/media/track/track-webvtt-tc003-newlines-expected.txt
    R LayoutTests/media/track/track-webvtt-tc003-newlines.html
    R LayoutTests/media/track/track-webvtt-tc004-magic-header-expected.txt
    R LayoutTests/media/track/track-webvtt-tc004-magic-header.html
    R LayoutTests/media/track/track-webvtt-tc005-header-comment-expected.txt
    R LayoutTests/media/track/track-webvtt-tc005-header-comment.html
    R LayoutTests/media/track/track-webvtt-tc006-cue-identifiers-expected.txt
    R LayoutTests/media/track/track-webvtt-tc006-cue-identifiers.html
    R LayoutTests/media/track/track-webvtt-tc007-cue-no-id-expected.txt
    R LayoutTests/media/track/track-webvtt-tc007-cue-no-id.html
    R LayoutTests/media/track/track-webvtt-tc008-timings-no-hours-expected.txt
    R LayoutTests/media/track/track-webvtt-tc008-timings-no-hours.html
    R LayoutTests/media/track/track-webvtt-tc009-timings-hour-expected.txt
    R LayoutTests/media/track/track-webvtt-tc009-timings-hour.html
    R LayoutTests/media/track/track-webvtt-tc010-no-timings-expected.txt
    R LayoutTests/media/track/track-webvtt-tc010-no-timings.html
    R LayoutTests/media/track/track-webvtt-tc011-blank-lines-expected.txt
    R LayoutTests/media/track/track-webvtt-tc011-blank-lines.html
    R LayoutTests/media/track/track-webvtt-tc013-settings-expected.txt
    R LayoutTests/media/track/track-webvtt-tc013-settings.html
    R LayoutTests/media/track/track-webvtt-tc014-alignment-expected.txt
    R LayoutTests/media/track/track-webvtt-tc014-alignment.html
    R LayoutTests/media/track/track-webvtt-tc015-positioning-expected.txt
    R LayoutTests/media/track/track-webvtt-tc015-positioning.html
    R LayoutTests/media/track/track-webvtt-tc016-align-positioning-expected.txt
    R LayoutTests/media/track/track-webvtt-tc016-align-positioning.html
    R LayoutTests/media/track/track-webvtt-tc017-line-position-expected.txt
    R LayoutTests/media/track/track-webvtt-tc017-line-position.html
    R LayoutTests/media/track/track-webvtt-tc018-align-text-line-position-expected.txt
    R LayoutTests/media/track/track-webvtt-tc018-align-text-line-position.html
    R LayoutTests/media/track/track-webvtt-tc020-cue-size-align-expected.txt
    R LayoutTests/media/track/track-webvtt-tc020-cue-size-align.html
    R LayoutTests/media/track/track-webvtt-tc021-valign-expected.txt
    R LayoutTests/media/track/track-webvtt-tc021-valign.html
    R LayoutTests/media/track/track-webvtt-tc022-entities-expected.txt
    R LayoutTests/media/track/track-webvtt-tc022-entities.html
    R LayoutTests/media/track/track-webvtt-tc023-markup-expected.txt
    R LayoutTests/media/track/track-webvtt-tc023-markup.html
    R LayoutTests/media/track/track-webvtt-tc024-timestamp-expected.txt
    R LayoutTests/media/track/track-webvtt-tc024-timestamp.html
    R LayoutTests/media/track/track-webvtt-tc025-class-markup-expected.txt
    R LayoutTests/media/track/track-webvtt-tc025-class-markup.html
    R LayoutTests/media/track/track-webvtt-tc026-voice-expected.txt
    R LayoutTests/media/track/track-webvtt-tc026-voice.html
    R LayoutTests/media/track/track-webvtt-tc027-empty-cue-expected.txt
    R LayoutTests/media/track/track-webvtt-tc027-empty-cue.html
    R LayoutTests/media/track/track-webvtt-tc028-unsupported-markup-expected.txt
    R LayoutTests/media/track/track-webvtt-tc028-unsupported-markup.html
    R LayoutTests/media/track/track-webvtt-tc029-timings-whitespace-expected.txt
    R LayoutTests/media/track/track-webvtt-tc029-timings-whitespace.html
    R LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue-expected.txt
    R LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue.html
    R LayoutTests/media/track/track-webvtt-tc031-cue-recovery-expected.txt
    R LayoutTests/media/track/track-webvtt-tc031-cue-recovery.html
    R LayoutTests/media/track/track-webvtt-tc032-degenerate-cues-expected.txt
    R LayoutTests/media/track/track-webvtt-tc032-degenerate-cues.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac/TestExpectations

  Log Message:
  -----------
  Remove local `track` tests in favor of WPT

https://bugs.webkit.org/show_bug.cgi?id=269655

Reviewed by Eric Carlson.

This is preliminary effort to de-duplicate bunch of local tests in
`media` specifically `track` in favor of WPT tests:

> Renamed `vtt-region-parser.html ` to WPT `header-regions.html`
* LayoutTests/media/track/regions-webvtt/vtt-region-parser.html: Deleted
* LayoutTests/media/track/regions-webvtt/vtt-region-parser-expected.txt: Ditto
Reference: https://chromium.googlesource.com/chromium/src.git/+/ad11f82eeaba1fb9ad63c45809825d840e7ce44c

> Removed local copies `track-cues-cuechange.html` and
`track-cues-enter-exit.html` in favor of WPT with same name
> Deleted `resource` file `cues-chrono-order.vtt` as well
* LayoutTests/media/track/captions-webvtt/cues-chrono-order.vtt: Deleted
* LayoutTests/media/track/track-cues-cuechange.html: Deleted
* LayoutTests/media/track/track-cues-cuechange-expected.txt: Ditto
* LayoutTests/media/track/track-cues-enter-exit.html: Ditto
* LayoutTests/media/track/track-cues-enter-exit-expected.txt: Ditto
Reference: https://chromium.googlesource.com/chromium/src.git/+/abe01ca5f57b5cf02dcc0d65a3c022d599eb56c3

> Deleted `track-node-add-remove.html` in favor of WPT Test with same name
* LayoutTests/media/track/track-node-add-remove.html: Deleted
* LayoutTests/media/track/track-node-add-remove-expected.txt: Ditto
Reference: https://chromium.googlesource.com/chromium/src.git/+/c2009a32aabb712fbba4955ac0e86986e56e9ad4

> Remove local copies of below tests in favor of WPT:
* LayoutTests/media/track/track-remove-track.html: With same name
* LayoutTests/media/track/track-remove-track-expected.txt:
* LayoutTests/media/track/track-remove-active-cue-crash.html: With 'track-remove-active-cue.html' name
* LayoutTests/media/track/track-remove-active-cue-crash-expected.txt:
* LayoutTests/media/track/track-node-add-remove.html: With same name
* LayoutTests/media/track/track-node-add-remove-expected.txt:
* LayoutTests/media/track/track-cues-enter-exit.html: With same name
* LayoutTests/media/track/track-cues-enter-exit-expected.txt:
* LayoutTests/media/track/track-active-cues.html: With same name
* LayoutTests/media/track/track-active-cues-expected.txt

> Removed `crossOrigin.html` in favor of WPT with same name
* LayoutTests/media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html: Deleted
Reference: https://chromium.googlesource.com/chromium/src.git/+/8dea498d5fcc87730ac1f9e294d08a053184e68c

> Removed `track-constants.html` now in `readyState.html` on WPT
* LayoutTests/media/track/track-constants.html: Deleted
* LayoutTests/media/track/track-constants-expected.txt: Deleted
Reference: https://chromium.googlesource.com/chromium/src.git/+/b6f9344a2370bc3970643a2a532655fffe5568e9

> Remove local `track-webvtt-tc[001-032]-*.html` in favor of WPT:
* WPT Directory - 'html/semantics/embedded-content/media-elements/track/track-element'
and starting with 'track-webvtt-' (e.g. track-webvtt-tc001-utf8.html
-> track-webvtt-utf8.html)
Reference: https://chromium.googlesource.com/chromium/src.git/+/253def87b2e0d66fe0af3f8bce11409469668858
https://chromium.googlesource.com/chromium/src.git/+/21025b8461ad6d5d90bdfa296171bddd755afd5f
https://chromium.googlesource.com/chromium/src.git/+/a14d026f402dfc66216603926eff6593be4e012c
https://chromium.googlesource.com/chromium/src.git/+/bc34071d92d7dbcd5425d7b8991b6f0399b351b1
https://chromium.googlesource.com/chromium/src.git/+/d33b073d775c0d21cfb94f54da743c1015acf93d
https://chromium.googlesource.com/chromium/src.git/+/20fe39102f1ee7c1548ecf43937a0cf07a4666b0
* Remove local resource files as well from: `LayoutTests/media/track/captions-webvtt/`
(for above tests)

> Update 'TestExpectation' files:
* LayoutTests/platform/glib/TestExpectations: Updated
* LayoutTests/platform/mac-wk1/TestExpectations: Ditto
* LayoutTests/platform/mac/TestExpectations: Ditto

Canonical link: https://commits.webkit.org/274948@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list