[webkit-changes] [WebKit/WebKit] 5a6b1d: [macOS] Screen or Window sharing in Safari stops w...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a6b1df677bb4f923e701a549498e87337f51c07
      https://github.com/WebKit/WebKit/commit/5a6b1df677bb4f923e701a549498e87337f51c07
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2024-02-18 (Sun, 18 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h
    M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm

  Log Message:
  -----------
  [macOS] Screen or Window sharing in Safari stops working once paused, resume option does not work - WebRTC getDisplayMedia
https://bugs.webkit.org/show_bug.cgi?id=269566
rdar://122187886

Reviewed by Eric Carlson.

When muting the source, we stop it.
At that point, we were forgetting which content filter we were using, which is necessary to restart the stream.
We are now storing it in ScreenCaptureKitCaptureSource by querying ScreenCaptureKitSharingSessionManager.
When unmuting, we already have it and we can construct successfully a new session source.

* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm:
(WebCore::ScreenCaptureKitSharingSessionManager::cancelPendingSessionForDevice):
(WebCore::ScreenCaptureKitSharingSessionManager::contentFilterFromCaptureDevice):
(WebCore::ScreenCaptureKitSharingSessionManager::createSessionSourceForDevice):

Canonical link: https://commits.webkit.org/274943@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications