[webkit-changes] [WebKit/WebKit] 345a31: Remove non-standard `VTTRegion.track`

Ahmad Saleem noreply at github.com
Sat Feb 17 19:36:50 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 345a3158dfec00a635894d05ee186d24c16ec777
      https://github.com/WebKit/WebKit/commit/345a3158dfec00a635894d05ee186d24c16ec777
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-02-17 (Sat, 17 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt
    R LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt
    R LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html
    M Source/WebCore/html/track/InbandGenericTextTrack.cpp
    M Source/WebCore/html/track/InbandWebVTTTextTrack.cpp
    M Source/WebCore/html/track/LoadableTextTrack.cpp
    M Source/WebCore/html/track/TextTrack.cpp
    M Source/WebCore/html/track/VTTRegion.cpp
    M Source/WebCore/html/track/VTTRegion.h
    M Source/WebCore/html/track/VTTRegion.idl

  Log Message:
  -----------
  Remove non-standard `VTTRegion.track`

https://bugs.webkit.org/show_bug.cgi?id=269649

Reviewed by Eric Carlson.

This patch is to align WebKit with Blink / Chromium, Gecko / Firefox and Web Specification [1]:

[1] https://w3c.github.io/webvtt/#the-vttregion-interface

It was removed from the web-spec in following:

W3C Bug - https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380
WebVTT GitHub Commit - https://github.com/w3c/webvtt/pull/31

* Source/WebCore/html/track/VTTRegion.cpp:
(VTTRegion::setTrack):
* Source/WebCore/html/track/VTTRegion.h:
* Source/WebCore/html/track/VTTRegion.idl:
* Source/WebCore/html/track/InbandGenericTextTrack.cpp:
(InbandGenericTextTrack::newRegionsParsed):
* Source/WebCore/html/track/InbandWebVTTTextTrack.cpp:
(InbandWebVTTTextTrack::newRegionsParsed):
* Source/WebCore/html/track/LoadableTextTrack.cpp:
(LoadableTextTrack::newRegionsAvailable):
* LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt: Rebaselined
* LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html: Removed in
favor of WPT Test: `webvtt/api/VTTRegion/constructor.html`
* LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt: Deleted Test Expectations

Canonical link: https://commits.webkit.org/274936@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list