[webkit-changes] [WebKit/WebKit] bda7fd: Skip repeated sanitizeValue call

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bda7fd807e52fe81d2433ac8b8aaa0d7be243f84
      https://github.com/WebKit/WebKit/commit/bda7fd807e52fe81d2433ac8b8aaa0d7be243f84
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/Element.h
    M Source/WebCore/html/HTMLInputElement.cpp
    M Source/WebCore/html/HTMLInputElement.h

  Log Message:
  -----------
  Skip repeated sanitizeValue call
https://bugs.webkit.org/show_bug.cgi?id=269618
rdar://123118619

Reviewed by Ryosuke Niwa.

Based on Ryosuke's patch, we clean up Element::parserSetAttributes and avoid repeated sanitizeValue calls.
When we are creating HTMLInputElement from parser, we do not need to update type and value in attributeChanged.
They are already initialized correctly in parserSetAttributes.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::parserDidSetAttributes): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parserInitializeInputType):
(WebCore::HTMLInputElement::attributeChanged):
(WebCore::HTMLInputElement::initializeInputType): Deleted.
(WebCore::HTMLInputElement::parserDidSetAttributes): Deleted.
* Source/WebCore/html/HTMLInputElement.h:

Canonical link: https://commits.webkit.org/274904@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications