[webkit-changes] [WebKit/WebKit] 6c9a59: [Site Isolation] Aggregate find string match counts

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c9a595ac127781f1c0e17cbb0dabade2ee2334f
      https://github.com/WebKit/WebKit/commit/6c9a595ac127781f1c0e17cbb0dabade2ee2334f
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp
    M Source/WebKit/UIProcess/FindStringCallbackAggregator.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindStringFindDelegate.h
    A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindStringFindDelegate.mm

  Log Message:
  -----------
  [Site Isolation] Aggregate find string match counts
https://bugs.webkit.org/show_bug.cgi?id=269551
rdar://123067488

Reviewed by Alex Christensen.

The find string callback aggregator should sum the match counts from each web process response.

Also reuse the find delegate in `WKWebViewFindString.mm`.

* Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp:
(WebKit::FindStringCallbackAggregator::foundString):
(WebKit::FindStringCallbackAggregator::~FindStringCallbackAggregator):
* Source/WebKit/UIProcess/FindStringCallbackAggregator.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findString):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
(-[WKWebViewFindStringFindDelegate findString]): Deleted.
(-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]): Deleted.
(-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]): Deleted.
(-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]): Deleted.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindStringFindDelegate.h: Copied from Source/WebKit/UIProcess/FindStringCallbackAggregator.h.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindStringFindDelegate.mm: Copied from Source/WebKit/UIProcess/FindStringCallbackAggregator.h.
(-[WKWebViewFindStringFindDelegate findString]):
(-[WKWebViewFindStringFindDelegate _webView:didCountMatches:forString:]):
(-[WKWebViewFindStringFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
(-[WKWebViewFindStringFindDelegate _webView:didFailToFindString:]):

Canonical link: https://commits.webkit.org/274897@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications