[webkit-changes] [WebKit/WebKit] 3fb565: [WebGPU] Newly added https://gpuweb.github.io/cts/...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3fb5654412fea60ab6b36b727c157b22570e2f1a
      https://github.com/WebKit/WebKit/commit/3fb5654412fea60ab6b36b727c157b22570e2f1a
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebGPU/WebGPU/BindGroupLayout.h
    M Source/WebGPU/WebGPU/BindGroupLayout.mm
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/PipelineLayout.h
    M Source/WebGPU/WebGPU/PipelineLayout.mm

  Log Message:
  -----------
  [WebGPU] Newly added https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,encoding,programmable,pipeline_bind_group_compat:default_bind_group_layouts_never_match,* is failing (
https://bugs.webkit.org/show_bug.cgi?id=269337
<radar://122922404>

Reviewed by Tadeu Zagallo.

This test was added five days ago, we missed a check from the spec
which says that the pipeline layouts of the bind group layouts must
be compared for equality, if those bind group layouts were automatically
generated.

With the additional check, the new CTS tests pass in MiniBrowser.

* Source/WebGPU/WebGPU/BindGroupLayout.h:
* Source/WebGPU/WebGPU/BindGroupLayout.mm:
(WebGPU::BindGroupLayout::errorValidatingBindGroupCompatibility const):
(WebGPU::BindGroupLayout::autogeneratedPipelineLayout const):
(WebGPU::BindGroupLayout::setAutogeneratedPipelineLayout):
(WebGPU::BindGroupLayout::isAutoGenerated const):
* Source/WebGPU/WebGPU/Device.mm:
(wgpuDeviceCreatePipelineLayout):
* Source/WebGPU/WebGPU/PipelineLayout.h:
(WebGPU::PipelineLayout::create):
(WebGPU::PipelineLayout::isAutoLayout const): Deleted.
* Source/WebGPU/WebGPU/PipelineLayout.mm:
(WebGPU::Device::createPipelineLayout):
(WebGPU::PipelineLayout::isAutoLayout const):
(WebGPU::PipelineLayout::PipelineLayout):

Canonical link: https://commits.webkit.org/274866@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications