[webkit-changes] [WebKit/WebKit] 062609: [UnifiedPDF] After resizing the window, PDF conten...

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0626093f8437aac279859fab6584d2670c5e76c4
      https://github.com/WebKit/WebKit/commit/0626093f8437aac279859fab6584d2670c5e76c4
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] After resizing the window, PDF content is not centered and hit testing is offset
https://bugs.webkit.org/show_bug.cgi?id=269549
rdar://123066513

Reviewed by Tim Horton.

The PDF content is centered in the window via a transform on the m_contentsLayer layer.
We need to update this transform both when the scale factor changes, but also when
layout is updated.

This is a small change to fix the issue. A larger refactoring of the "update" functions
is needed.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerPositions):
(WebKit::UnifiedPDFPlugin::setPageScaleFactor):
(WebKit::UnifiedPDFPlugin::updateLayout):

Canonical link: https://commits.webkit.org/274859@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications