[webkit-changes] [WebKit/WebKit] e7ee3a: [threaded-animation-resolution] don't accelerate t...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e7ee3a4fe869d087dc98d27686c84c5e2343f2ee
      https://github.com/WebKit/WebKit/commit/e7ee3a4fe869d087dc98d27686c84c5e2343f2ee
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/animation/AcceleratedEffect.cpp
    M Source/WebCore/platform/animation/AcceleratedEffect.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp

  Log Message:
  -----------
  [threaded-animation-resolution] don't accelerate transform interpolation on inline renderers
https://bugs.webkit.org/show_bug.cgi?id=269568

Reviewed by Dean Jackson.

Inline renderers don't support transform-related properties so there is no need to accelerate
interpolation of the transform property on such targets.

Since we now have several reasons why transform-related properties cannot be accelerated, we now
keep an `OptionSet<AcceleratedEffectProperty>` that indicates the set of accelerated properties that
were not allowed, passing it down to the `AcceleratedEffect` and removing the disallowed properties
all at once, including those that are marked at disallowed during construction of the `AcceleratedEffect`.

Now, when we encounter an inline renderer, we add the transform-related properties to the list
of disallowed properties.

* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::AcceleratedEffect::create):
(WebCore::AcceleratedEffect::AcceleratedEffect):
(WebCore::AcceleratedEffect::validateFilters):
* Source/WebCore/platform/animation/AcceleratedEffect.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAcceleratedEffectsAndBaseValues):

Canonical link: https://commits.webkit.org/274850@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications