[webkit-changes] [WebKit/WebKit] 8f9efa: [JSC] Use offlineasm globl to ensure that all entr...

Yusuke Suzuki noreply at github.com
Fri Feb 16 09:43:28 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f9efa2df4fd840f10a2d478fd8a7f309248bb4e
      https://github.com/WebKit/WebKit/commit/8f9efa2df4fd840f10a2d478fd8a7f309248bb4e
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/JavaScriptCore/llint/LowLevelInterpreter.asm
    M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
    M Source/JavaScriptCore/offlineasm/asm.rb
    M Source/JavaScriptCore/offlineasm/ast.rb
    M Source/JavaScriptCore/offlineasm/backends.rb
    M Source/JavaScriptCore/offlineasm/cloop.rb
    M Source/JavaScriptCore/offlineasm/parser.rb

  Log Message:
  -----------
  [JSC] Use offlineasm globl to ensure that all entries have alt_entry, take 2
https://bugs.webkit.org/show_bug.cgi?id=269553
rdar://122525586

Reviewed by Justin Michaud.

Take 2. Previously we used `global` for vmEntryToCSSJIT. But this is not correct since it hides the symbol.
We need `globalexport`, which makes symbol visible. This patch adds `globalexport`. Also, we correctly applied it to jitCagePtr
function too.

* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
* Source/JavaScriptCore/offlineasm/asm.rb:
* Source/JavaScriptCore/offlineasm/ast.rb:
* Source/JavaScriptCore/offlineasm/backends.rb:
* Source/JavaScriptCore/offlineasm/cloop.rb:
* Source/JavaScriptCore/offlineasm/parser.rb:

Canonical link: https://commits.webkit.org/274845@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list