[webkit-changes] [WebKit/WebKit] f7b645: [UnifiedPDF] Set the scrollability on the main con...

Simon Fraser noreply at github.com
Fri Feb 16 09:19:10 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7b645811ea58be3d4cb17644f2f6cca5e1534ae
      https://github.com/WebKit/WebKit/commit/f7b645811ea58be3d4cb17644f2f6cca5e1534ae
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/ScrollableArea.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Set the scrollability on the main content layer
https://bugs.webkit.org/show_bug.cgi?id=269541
rdar://123063794

Reviewed by Tim Horton.

There are two things we can do to optimize tile size, and tile coverage on the
UnifiedPDFPlugin's main content layer.

First, by calling `setScrollability()`, the TileController can decide between 512x512 tiles,
and tiles that stretch the width of the layer.

Second, by using a GraphicsLayer type of `PageTiledBacking` when the plugin is the main
frame plugin, GraphicsLayerCA makes tile coverage decisions that are more appropriate for
the main frame scroller.

* Source/WebCore/platform/ScrollableArea.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::ensureLayers):
(WebKit::UnifiedPDFPlugin::isFullMainFramePlugin const):
(WebKit::UnifiedPDFPlugin::computeScrollability const):
(WebKit::UnifiedPDFPlugin::updateScrollingExtents):

Canonical link: https://commits.webkit.org/274837@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list