[webkit-changes] [WebKit/WebKit] 402f87: [macOS] Implement _isInWindowActive SPI

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 402f8772f2520846e873094226fe4bdb43be14d3
      https://github.com/WebKit/WebKit/commit/402f8772f2520846e873094226fe4bdb43be14d3
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/PlaybackSessionModel.h
    M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h
    M Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm
    M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
    M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h
    M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
    M Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in
    M Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.h
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h
    M Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm
    M Tools/MiniBrowser/mac/BrowserWindowController.h
    M Tools/MiniBrowser/mac/BrowserWindowController.m
    M Tools/MiniBrowser/mac/MainMenu.xib
    M Tools/MiniBrowser/mac/WK2BrowserWindowController.m
    M Tools/TestWebKitAPI/SourcesCocoa.txt
    M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
    A Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm

  Log Message:
  -----------
  [macOS] Implement _isInWindowActive SPI
https://bugs.webkit.org/show_bug.cgi?id=269499
rdar://122827633

Reviewed by Andy Estes.

Implement _isInWindowActive by pushing activation state up from the WebContent
process to be cached locally in the UIProcess for ease of querying.

- Rename isInWindow() to isInWindowFullscreen() in a number of places,
  for disambiguation reasons.

- Add Debug menu items to MiniBrowser to toggle both in-window fullscreen
  and picture-in-picture modes for testing purposes.

- Add API tests for both availability and active states of in-window fullscreen.

* Source/WebCore/platform/cocoa/PlaybackSessionModel.h:
(WebCore::PlaybackSessionModelClient::isInWindowFullscreenActiveChanged):
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.h:
* Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::updateForEventName):
(WebCore::PlaybackSessionModelMediaElement::toggleInWindowFullscreen):
(WebCore::PlaybackSessionModelMediaElement::observedEventNames):
(WebCore::PlaybackSessionModelMediaElement::isInWindowFullscreenActive const):
(WebCore::PlaybackSessionModelMediaElement::toggleInWindow): Deleted.
* Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm:
* Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.h:
* Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm:
(WebCore::PlaybackSessionInterfaceMac::isInWindowFullscreenActive const):
(WebCore::PlaybackSessionInterfaceMac::toggleInWindowFullscreen):
(WebCore::PlaybackSessionInterfaceMac::setPlayBackControlsManager):
* Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:
(-[WebPlaybackControlsManager toggleInWindow]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isInWindowActive]):
(-[WKWebView _toggleInWindow]):
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
* Source/WebKit/UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:
(WebKit::PlaybackSessionModelContext::toggleInWindowFullscreen):
(WebKit::PlaybackSessionModelContext::isInWindowFullscreenActiveChanged):
(WebKit::PlaybackSessionManagerProxy::isInWindowFullscreenActiveChanged):
(WebKit::PlaybackSessionModelContext::toggleInWindow): Deleted.
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.h:
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController setInWindowFullscreenActive:]):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::isInWindowFullscreenActive const):
(WebKit::WebViewImpl::toggleInWindowFullscreen):
(WebKit::WebViewImpl::toggleInWindow): Deleted.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.h:
* Source/WebKit/WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionInterfaceContext::isInWindowFullscreenActiveChanged):
(WebKit::PlaybackSessionManager::isInWindowFullscreenActiveChanged):
(WebKit::PlaybackSessionManager::toggleInWindow):
* Tools/MiniBrowser/mac/BrowserWindowController.h:
* Tools/MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController togglePictureInPicture:]):
(-[BrowserWindowController toggleInWindowFullscreen:]):
* Tools/MiniBrowser/mac/MainMenu.xib:
* Tools/MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController togglePictureInPicture:]):
(-[WK2BrowserWindowController toggleInWindowFullscreen:]):
(-[WK2BrowserWindowController validateMenuItem:]):
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/mac/InWindowFullscreen.mm: Added.
(TestWebKitAPI::createInWindowFullscreenWebView):
(TestWebKitAPI::testEventually):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/274832@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications