[webkit-changes] [WebKit/WebKit] 06c272: Remove access from MediaPlayerPrivateMediaSource t...

Jean-Yves Avenard noreply at github.com
Fri Feb 16 06:09:59 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06c27265e8ab06e41c4f2265e3bba67d08446177
      https://github.com/WebKit/WebKit/commit/06c27265e8ab06e41c4f2265e3bba67d08446177
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M Source/WebCore/Modules/mediasource/MediaSource.cpp
    M Source/WebCore/Modules/mediasource/MediaSource.h
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/platform/graphics/MediaSourcePrivate.cpp
    M Source/WebCore/platform/graphics/MediaSourcePrivate.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
    M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
    M Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp

  Log Message:
  -----------
  Remove access from MediaPlayerPrivateMediaSource to MediaSourcePrivate::buffered
https://bugs.webkit.org/show_bug.cgi?id=269560
rdar://problem/123074982

Reviewed by Youenn Fablet.

When a MediaSource object is in use, the HTMLMediaElement retrieves the buffered
directly from it rather than from the MediaPlayer/MediaPlayerPrivate.

As such, we don't need to implement the buffered method for the MediaPlayerPrivateMediaSourceX.

No change in observable behaviour, Covered by existing tests.
* Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::buffered const):
(WebCore::MediaSource::hasBufferedTime):
* Source/WebCore/Modules/mediasource/MediaSource.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerBufferedTimeRangesChanged):
* Source/WebCore/platform/graphics/MediaSourcePrivate.cpp:
(WebCore::MediaSourcePrivate::hasFutureTime const):
(WebCore::MediaSourcePrivate::duration const):
(WebCore::MediaSourcePrivate::buffered const):
* Source/WebCore/platform/graphics/MediaSourcePrivate.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered const):
* Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::buffered const):
* Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::buffered const):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):

Canonical link: https://commits.webkit.org/274824@main




More information about the webkit-changes mailing list