[webkit-changes] [WebKit/WebKit] d876c0: REGRESSION (273714 at main): [ iOS 17 wk2 ] imported/...

Alan Baradlay noreply at github.com
Fri Feb 16 05:08:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d876c093f5a928646a4ec2983a89852d1bda98e7
      https://github.com/WebKit/WebKit/commit/d876c093f5a928646a4ec2983a89852d1bda98e7
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M LayoutTests/platform/ios-wk2/TestExpectations
    M LayoutTests/platform/ios-wk2/css2.1/t1508-c527-font-09-b-expected.txt
    M LayoutTests/platform/ios/compositing/overflow/nested-scrolling-expected.txt
    M LayoutTests/platform/ios/css1/font_properties/font-expected.txt
    M LayoutTests/platform/ios/css1/text_properties/line_height-expected.txt
    M LayoutTests/platform/ios/fast/block/positioning/047-expected.txt
    M LayoutTests/platform/ios/fast/borders/border-radius-split-inline-expected.txt
    M LayoutTests/platform/ios/fast/css/negative-leading-expected.txt
    M LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/ios/fast/overflow/infiniteRecursionGuard-expected.txt
    M LayoutTests/platform/ios/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac-monterey/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac-monterey/tables/mozilla/bugs/bug2479-2-expected.txt
    M LayoutTests/platform/mac/css1/font_properties/font-expected.txt
    M LayoutTests/platform/mac/css1/text_properties/line_height-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-00-d-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-02-d-expected.txt
    M LayoutTests/platform/mac/css2.1/t090501-c414-flt-ln-03-d-expected.txt
    M LayoutTests/platform/mac/fast/block/positioning/047-expected.txt
    M LayoutTests/platform/mac/fast/css/negative-leading-expected.txt
    M LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt
    M LayoutTests/platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
    M LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  -----------
  REGRESSION (273714 at main): [ iOS 17 wk2 ] imported/w3c/web-platform-tests/css/css-fonts/font-size-adjust-zero-1.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=269246

Reviewed by Antti Koivisto.

Since 273714 at main, InlineBox::preferredLineHeight returns non-integral value, but the
integral -> float transition can only happen here when ascent/descent become all non-integral.

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):

Canonical link: https://commits.webkit.org/274818@main




More information about the webkit-changes mailing list