[webkit-changes] [WebKit/WebKit] 9ce832: Apply SVG paint-order to text-decorations

Ahmad Saleem noreply at github.com
Fri Feb 16 02:40:11 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ce832dcb0d37a68a7980d4a4251f92195e864f6
      https://github.com/WebKit/WebKit/commit/9ce832dcb0d37a68a7980d4a4251f92195e864f6
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-02-16 (Fri, 16 Feb 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp

  Log Message:
  -----------
  Apply SVG paint-order to text-decorations

https://bugs.webkit.org/show_bug.cgi?id=268825

Reviewed by Tim Nguyen.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and
Web-Specification [1] & [2]:

[1] https://svgwg.org/svg2-draft/painting.html#PaintOrder
[2] https://svgwg.org/svg2-draft/text.html#TextDecorationProperties

"The paint order of the text decoration itself (fill/stroke) is determined
by the value of the paint-order property at the point where the
text decoration is declared."

Merge: https://chromium.googlesource.com/chromium/blink/+/72eecba077f756ef4ed254541ff37dcb9baec05a

* Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
(SVGInlineTextBox::paintDecoration): 'for' loop similar to `paint()` function
* LayoutTests/TestExpectations: Remove passing test

Canonical link: https://commits.webkit.org/274814@main




More information about the webkit-changes mailing list