[webkit-changes] [WebKit/WebKit] 322e58: AX: Adopt non-blinking cursor API
Joshua Hoffman
noreply at github.com
Thu Feb 15 20:40:19 PST 2024
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 322e588ea0da59e5871fc52c3d29f3e0cd77617e
https://github.com/WebKit/WebKit/commit/322e588ea0da59e5871fc52c3d29f3e0cd77617e
Author: Joshua Hoffman <jhoffman23 at apple.com>
Date: 2024-02-15 (Thu, 15 Feb 2024)
Changed paths:
A LayoutTests/accessibility/mac/prefers-non-blinking-cursor-expected.txt
A LayoutTests/accessibility/mac/prefers-non-blinking-cursor.html
M LayoutTests/platform/mac/TestExpectations
M Source/WTF/wtf/PlatformEnable.h
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/FrameSelection.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/platform/CaretAnimator.cpp
M Source/WebCore/platform/CaretAnimator.h
M Source/WebCore/platform/DictationCaretAnimator.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h
M Source/WebKit/Shared/AccessibilityPreferences.h
M Source/WebKit/Shared/AccessibilityPreferences.serialization.in
M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebProcess.h
M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
Log Message:
-----------
AX: Adopt non-blinking cursor API
https://bugs.webkit.org/show_bug.cgi?id=268920
rdar://118550285
Reviewed by Tyler Wilcock.
This patch adopts a new accessibility API, _AXSPrefersNonBlinkingCursorIndicator, to
turns off caret blinking animations when enabled.
A new test was also added to verify this behavior.
* LayoutTests/accessibility/mac/prefers-non-blinking-cursor-expected.txt: Added.
* LayoutTests/accessibility/mac/prefers-non-blinking-cursor.html: Added.
* LayoutTests/platform/mac/TestExpectations:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::setPrefersNonBlinkingCursor):
* Source/WebCore/editing/FrameSelection.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setPrefersNonBlinkingCursor):
* Source/WebCore/page/Page.h:
(WebCore::Page::prefersNonBlinkingCursor const):
* Source/WebCore/platform/CaretAnimator.cpp:
(WebCore::CaretAnimator::isBlinkingSuspended const):
* Source/WebCore/platform/CaretAnimator.h:
(WebCore::CaretAnimator::setPrefersNonBlinkingCursor):
(WebCore::CaretAnimator::prefersNonBlinkingCursor const):
(WebCore::CaretAnimator::CaretAnimator):
(WebCore::CaretAnimator::isBlinkingSuspended const): Deleted.
* Source/WebCore/platform/DictationCaretAnimator.cpp:
(WebCore::DictationCaretAnimator::expandedCaretRect const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setPrefersNonBlinkingCursor):
(WebCore::Internals::isCaretBlinkingSuspended):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h:
* Source/WebKit/Shared/AccessibilityPreferences.h:
* Source/WebKit/Shared/AccessibilityPreferences.serialization.in:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::accessibilityPreferences):
(WebKit::WebProcessPool::registerNotificationObservers):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_unifiedTextReplacementController):
(WebKit::WebPage::updatePrefersNonBlinkingCursor):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::prefersNonBlinkingCursor const):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::accessibilityPreferencesDidChange):
(WebKit::WebProcess::updatePageAccessibilitySettings):
Canonical link: https://commits.webkit.org/274792@main
More information about the webkit-changes
mailing list