[webkit-changes] [WebKit/WebKit] caa1df: [WebGPU] ENABLE(WEBGPU_BY_DEFAULT) is non-functional

mwyrzykowski noreply at github.com
Thu Feb 15 17:57:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: caa1df095847aac66ac0e3637bcf4e09cb5283ad
      https://github.com/WebKit/WebKit/commit/caa1df095847aac66ac0e3637bcf4e09cb5283ad
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt
    M LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt
    M LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt
    M LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/Shared/WebPreferencesDefaultValues.h

  Log Message:
  -----------
  [WebGPU] ENABLE(WEBGPU_BY_DEFAULT) is non-functional
https://bugs.webkit.org/show_bug.cgi?id=269428
<radar://122988764>

Reviewed by Dan Glastonbury.

It was not possible to use ENABLE(WEBGPU_BY_DEFAULT) locally after
269988 at main, so create a define which evaluates to the appropriate
status based on whether or not the flag is on.

* Source/WTF/Scripts/GeneratePreferences.rb:
This check is not needed as validation will occur as a compile time error.
It prevents the use of preprocessor definitions, but I filed
https://bugs.webkit.org/show_bug.cgi?id=269475 to fix this better.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:

* LayoutTests/platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
* LayoutTests/platform/mac-wk2/fast/dom/navigator-detached-no-crash-expected.txt:
Update expectations.

Canonical link: https://commits.webkit.org/274784@main




More information about the webkit-changes mailing list