[webkit-changes] [WebKit/WebKit] 82c987: [SVG2] Add support for the 'turn' unit in <angle>

Karl Dubost noreply at github.com
Thu Feb 15 16:41:04 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82c987e62f88df8ecd31f4526b688c0bbfdba45d
      https://github.com/WebKit/WebKit/commit/82c987e62f88df8ecd31f4526b688c0bbfdba45d
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2024-02-15 (Thu, 15 Feb 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt
    M Source/WTF/wtf/MathExtras.h
    M Source/WebCore/svg/SVGAngle.h
    M Source/WebCore/svg/SVGAngleValue.cpp
    M Source/WebCore/svg/SVGAngleValue.h

  Log Message:
  -----------
  [SVG2] Add support for the 'turn' unit in <angle>
https://bugs.webkit.org/show_bug.cgi?id=267180
rdar://120840743

Reviewed by Anne van Kesteren.

This is adding the turn units to SVGAngle.
Note that the spec is saying that the IDL should not be modified.
https://svgwg.org/svg2-draft/types.html#__svg__SVGAngle__SVG_ANGLETYPE_UNKNOWN
And new units should be considered with the SVG_ANGLETYPE_UNKNOWN.

* Source/WTF/wtf/MathExtras.h:
(turn2grad):
(grad2turn):
* Source/WebCore/svg/SVGAngle.h:
(WebCore::SVGAngle::unitType const):
* Source/WebCore/svg/SVGAngleValue.cpp:
(WebCore::SVGAngleValue::value const):
(WebCore::SVGAngleValue::setValue):
(WebCore::SVGAngleValue::valueAsString const):
(WebCore::parseAngleType):
(WebCore::SVGAngleValue::newValueSpecifiedUnits):
(WebCore::SVGAngleValue::convertToSpecifiedUnits):
* Source/WebCore/svg/SVGAngleValue.h:

Co-authored-by: Anne van Kesteren <annevk at annevk.nl>
Canonical link: https://commits.webkit.org/274778@main




More information about the webkit-changes mailing list